Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/silindbl/include volume id mount #34

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

silindbl-msft
Copy link
Collaborator

Adds a volume/pv id to the mount calls, so we can reject mounts for PVs that already exists.

@coveralls
Copy link

coveralls commented Feb 9, 2024

Pull Request Test Coverage Report for Build 8333483875

Details

  • 4 of 25 (16.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 60.499%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/blob/nodeserver.go 0 1 0.0%
pkg/edgecache/manager.go 3 5 60.0%
pkg/edgecache/csi_mounts/csi_mounts.pb.go 0 5 0.0%
pkg/edgecache/blob_cache_volume/blob_cache_volume.pb.go 1 14 7.14%
Files with Coverage Reduction New Missed Lines %
pkg/edgecache/blob_cache_volume/blob_cache_volume.pb.go 1 15.0%
Totals Coverage Status
Change from base Build 8328195366: -0.2%
Covered Lines: 2400
Relevant Lines: 3967

💛 - Coveralls

@silindbl-msft silindbl-msft force-pushed the user/silindbl/include-volume-id-mount branch from 447ce60 to 51a3d04 Compare March 18, 2024 20:54
@silindbl-msft silindbl-msft reopened this Mar 19, 2024
@silindbl-msft silindbl-msft merged commit e57747f into staging Mar 19, 2024
18 of 20 checks passed
@silindbl-msft silindbl-msft deleted the user/silindbl/include-volume-id-mount branch March 19, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants